Open-Mesh » batman-adv

I've recompiled it.

fyi: The linked gluon ticket is mine.

fyi:
I would like to test this fix, but I don't know how. I would need a fixed batman-adv for my "supernodes". If I understood the problem, it wouldn't make sense to test the fix on the gluon nodes only, without patching the high-traffic supernodes, because if the supernodes confuse the flags, the gluon nodes could not fix it....
Can someone provide an how-to get a batman-adv with enabled fix?

Sure!

You can grab a version containing this patch via:

$ git clone https://git.open-mesh.org/batman-adv.git
$ cd batman-adv
$ git checkout v2017.2
$ git cherry-pick 382d020fe3fa528b1f
$ make

(Make sure, you have your kernel headers present/installed. In Debian, the linux-headers-<your-kernel-version> package for instance.)

Then load this newly, externally build kernel module with something like:

$ insmod <yourbuildfolder>/batman-adv/build/net/batman-adv/batman-adv.ko

Depending on your host configuration you might need to unload any other batman-adv version first:

$ modprobe -r batman-adv

And might need to load some dependencies manually via modprobe as insmod is not that smart (for instance "modprobe crc16" and "modprobe libcrc32c", check "dmesg" if you have errors while inserting your self built batman-adv.ko).

I've had some time to test it.
The problems seem to resist.

1. Is it important that ALL Nodes in the network have got the new and patched batman-adv?
2. The "clients" are gluon nodes connected via fastd. There is a ticket that BLA maybe broken:
https://github.com/freifunk-gluon/gluon/issues/1198

I've many reportings that the supernodes got packages with their own mac... i'm not sure if this is okay, and BLA handles it (just "detected") or if this is an error in batman-adv or gluon

which information should i provide? to find out what's happening?

I'm sorry. I've to report, that I missed to enable BLA on gateway level. I had never enabled it before. The logentries where new, so something is still wrong, because before upgrading these messages where not there. I have now enabled bla, so i can't tell what's happening. any hints what i should check?

Hi Andre,

Thanks for the additional feedback and testing!

Hm, BLA should be enabled by default since some versions ago. So I'm a little confused why you say you had to enable it on a gateway with batman-adv v2017.2 plus this TT sync patch.

No, you shouldn't need to patch all nodes to notice a difference. Upgrading central nodes, like gateways or nodes with a VPN connection, should reduce the impact of the issue already and should contain infected multicast TT entries to some degree. And upgrading nodes close to the zombie node which triggers the issue for you, should help, too.

Could you share the output of "batctl tg" from a patched gateway? So we can have an overview of the current degree of infection in your network? (e.g. multicast TT entries with a "W" or "I" flag are infected)