Project

General

Profile

Actions
Copy link

Bug #324

closed

(LEDE - batman-adv 2016.5) Setting aggregated_ogms in /etc/config/batman-adv not honoured; (parsing issue in /lib/batman-adv/config.sh)

Added by Edward Beech over 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Edward Beech
Target version:
2017.0
Start date:
01/17/2017
Due date:
% Done:

0%

Estimated time:
1.00 h

Description

Hi folks,

I've never contributed before, so I apologise if I've done this wrong; I'm still not 100% sure if this issue should be against OpenWrt/LEDE or batman-adv.

I have noticed that for some time now, it's not possible to set aggregated_ogms setting from /etc/config/batman-adv.

Here's why:

First, we declare some locals
...
(line 14) local aggregated_ogms ap_isolation bonding bridge_loop_avoidance distributed_arp_table fragmentation
...

Then we try to read the variable from the file
...
(line 18) config_get aggregated_ogms "$mesh" aggregated_ogms
...

And finally we go to set the object in the filesystem
...
(line 37) [ -n "$aggregate_ogms" ] && echo $aggregate_ogms > /sys/class/net/$mesh/mesh/aggregate_ogms
...

However- you will note that there is a typo/oversight in line 37, the reference is "aggregate_ogms" instead of "aggregated_ogms"; a directory listing shows that it should indeed be "aggregated_ogms".

  1. ls /sys/class/net/bat0/mesh/agg*
    /sys/class/net/bat0/mesh/aggregated_ogms

Correcting the typo resolves the issue, I've tested this on one of my devices (GLi MiFi - LEDE build).

Regards,

Ed

Actions
Copy link

Also available in: Atom PDF