Project

General

Profile

Bug #219

Lot of "TT inconsistency"

Added by Def D about 6 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
Start date:
07/01/2015
Due date:
% Done:

0%

Estimated time:

Description

Using maint branch

Into tanslation-table.c, the call to function set_bit/clear_bit is done with a mask (BATADV_ORIG_CAPA_HAS_TT) instead of bit number 2
Result: the bit 4 is updated

Into function batadv_tt_update_orig, the bit is checked by the mask, and it can never be set.
has_tt_init is always false => a full tt request is always sent

set_bit(BATADV_ORIG_CAPA_HAS_TT, &orig_node->capa_initialized);
BATADV_ORIG_CAPA_HAS_TT = BIT(2)

Hoping that my analysis is correct, and can help you.

History

#1

Updated by Linus L├╝ssing about 6 years ago

Urgh, correct, set_bit()/clear_bit() already does the masking with its own call to BIT_MASK()... sorry, my bad! Thanks for finding - any prefered "Reported-by" tag for the patch I would prepare and submit?

#2

Updated by Def D about 6 years ago

Reported-by: Def <>

Tanks you :)

#3

Updated by Marek Lindner about 6 years ago

  • Status changed from New to Closed

Thanks for reporting the issue. The fix has been merged.

#4

Updated by Sven Eckelmann over 4 years ago

  • Target version set to 2015.1

Also available in: Atom PDF