Bug #242
closedbatadv_neigh_node_release: Double batadv_hardif_neigh_put
0%
Description
batadv_neigh_node_release (and maybe other places) uses a get + a double put of batadv_hardif_neigh_put without a direct reference in batadv_hardif_neigh_node. So it could be that the reference which is free'd is actually for a different object in memory or maybe was never obtained.
It looks like there should be an explicit reference (pointer) in batadv_hardif_neigh_node to be sure that the correct reference is free'd.
Updated by Sven Eckelmann about 8 years ago
- Related to Bug #237: batadv_neigh_node_new: Missing list checks for *list_add* added
Updated by Sven Eckelmann about 8 years ago
Proof-of-concept patches are available in ecsv/no_double_trouble
RFC of the patch was submitted to the mailing list as https://patchwork.open-mesh.org/project/b.a.t.m.a.n./patch/1457258842-10389-2-git-send-email-sven@narfation.org/
Updated by Sven Eckelmann about 8 years ago
- Status changed from New to In Progress
I've posted the cleaned up version of the RFC as patch because there was no objection regarding the idea behind the fix.
Updated by Marek Lindner almost 8 years ago
- Status changed from In Progress to Closed
Sven Eckelmann wrote:
I've posted the cleaned up version of the RFC as patch because there was no objection regarding the idea behind the fix.
Merged! Thanks!