Project

General

Profile

Bug #188

logspam "net_ratelimit: X callbacks suppressed"

Added by André Gaul about 7 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
Start date:
05/30/2014
Due date:
% Done:

0%

Estimated time:

Description

The batman-adv module currently produces a lot of logspam of the form

[107051.330000] net_ratelimit: 44 callbacks suppressed
[107325.800000] net_ratelimit: 88 callbacks suppressed
[107585.650000] net_ratelimit: 23 callbacks suppressed

This is caused by the definition of net_ratelimited_function in compat.h because net_ratelimit() is called independent of the current debug level. Thus net_ratelimit() prints the above messages although the actual message would not be printed.

The issue can be fixed trivially by calling net_ratelimit() after the debug level has been checked.

History

#1

Updated by Marek Lindner about 7 years ago

Do you mind taking the next step and send a patch to the mailing list ? Seems you have analyzed the problem already ..

#2

Updated by André Gaul about 7 years ago

Yes, I can take some minutes later today. I'm not very familiar with the batman-adv code yet, but this definitely is a low-hanging fruit... ;)

#3

Updated by André Gaul about 7 years ago

I prepared a patch, see https://github.com/andrenarchy/batman-adv/commit/30ff8cf671a84875b2605c3cb5103639979763d4 .

It's not yet tested. Can you review the code? Thx!

#4

Updated by Marek Lindner about 7 years ago

Typically, patches are sent to the mailing list for review. For more information see the 'submitting patches' section here: Contribute

#6

Updated by Marek Lindner over 6 years ago

  • Status changed from New to Closed

Has been merged. Thanks!

#7

Updated by Sven Eckelmann over 4 years ago

  • Target version set to 2014.4.0

Also available in: Atom PDF