Open-Mesh » batman-adv

Just looked through the multicast code and noticed:

    batadv_tvlv_handler_register(bat_priv, NULL, NULL,
                     batadv_mcast_forw_tracker_tvlv_handler,
                     BATADV_TVLV_MCAST_TRACKER, 1,
                     BATADV_TVLV_HANDLER_OGM_CIFNOTFND);

The BATADV_TVLV_HANDLER_OGM_CIFNOTFND doesn't seem to make a lot of sense here. This handler is for mptr/mcast_handler but the BATADV_TVLV_HANDLER_OGM_CIFNOTFND is only defined for optr/ogm_handler. See also in batadv_tvlv_containers_process

    if (packet_type != BATADV_IV_OGM &&
        packet_type != BATADV_OGM2)
        return ret;

    rcu_read_lock();
    hlist_for_each_entry_rcu(tvlv_handler,
                 &bat_priv->tvlv.handler_list, list) {
        if (!tvlv_handler->ogm_handler)
            continue;

        if ((tvlv_handler->flags & BATADV_TVLV_HANDLER_OGM_CIFNOTFND) &&
            !(tvlv_handler->flags & BATADV_TVLV_HANDLER_OGM_CALLED))
            tvlv_handler->ogm_handler(bat_priv, orig_node,
                          cifnotfound, NULL, 0);

I would therefore guess that the last parameter of batadv_mcast_forw_tracker_tvlv_handler should be 0