Project

General

Profile

Actions

Bug #442

closed

frag: batadv_frag_skb_fwd() modifies TTL without writable skb

Added by Sven Eckelmann 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Target version:
Start date:
06/10/2026
Due date:
% Done:

0%

Estimated time:

Description

The skb data must be writable before it can be modified (see skb_cow). But batadv_frag_skb_fwd just decrements ttl without making sure this is the case. Also the caller batadv_recv_frag_packet isn't checking for this.

Big question is: why do we modify the ttl at all? This is never checked for fragments.

Actions #1

Updated by Sven Eckelmann 4 months ago

  • Subject changed from frag: batadv_frag_skb_fwd() modifies TTL without writable header to frag: batadv_frag_skb_fwd() modifies TTL without writable skb
  • Description updated (diff)
Actions #2

Updated by Sven Eckelmann 4 months ago

Here is also an report from Sashiko about the same problem: https://sashiko.dev/#/patchset/20260610-ip_checksum-v1-0-0fd7f471dca3@narfation.org?part=1

Actions #3

Updated by Sven Eckelmann 4 months ago

  • Target version set to 2026.2
Actions #4

Updated by Sven Eckelmann 4 months ago

  • Status changed from New to In Progress
Actions #5

Updated by Sven Eckelmann 4 months ago

  • Status changed from In Progress to Resolved
Actions #6

Updated by Sven Eckelmann 4 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF