Project

General

Profile

Feature #424

Ping sleep even when sending one packet

Added by Roman Le bg 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Low
Assignee:
batman-adv developers
Target version:
Start date:
04/22/2022
Due date:
% Done:

100%

Estimated time:

Description

Hello, a small change would be required to make the utility not sleep for another packet if there isn't one.
Pinging an ip with the ip command return instantly if one packet is sent.

see

# time batctl p b8:27:eb:d6:b6:6f -c 1
PING b8:27:eb:d6:b6:6f (b8:27:eb:d6:b6:6f) 20(48) bytes of data
20 bytes from b8:27:eb:d6:b6:6f icmp_seq=1 ttl=50 time=8.77 ms
--- b8:27:eb:d6:b6:6f ping statistics ---
1 packets transmitted, 1 received, 0% packet loss
rtt min/avg/max/mdev = 8.769/8.769/8.769/0.000 ms

real    0m1.033s
user    0m0.020s
sys     0m0.002s

History

#1

Updated by Sven Eckelmann 2 months ago

  • Tracker changed from Bug to Feature
#2

Updated by Sven Eckelmann 2 months ago

  • Estimated time deleted (0.20 h)

If you have a (small) change then it is expected that you submit them and not ask other people to redo it (in hope that they do it as you intended). See Contribute

#3

Updated by Roman Le bg 2 months ago

Hello, unfortunately I'm not able to make a patch by myself.

Tell me if there are similar steps to request a change.

Thank you

#4

Updated by Sven Eckelmann 2 months ago

Hello, unfortunately I'm not able to make a patch by myself.

Then please don't tell other people how hard or easy a change is. And don't tell them how much time they will have to spend on implementing it.

#5

Updated by Roman Le bg 2 months ago

Alright, will not make the same mistake if I'll ever propose a change. Feel free to edit my post.

Thank you

#6

Updated by Sven Eckelmann 2 months ago

  • % Done changed from 0 to 100
  • Target version set to 2022.1
  • Status changed from New to Resolved
#7

Updated by Roman Le bg 2 months ago

Awesome ! Thank you for your work.

#8

Updated by Sven Eckelmann about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF