https://www.open-mesh.org/https://www.open-mesh.org/favicon.ico?16699090422016-11-01T12:12:50ZOpen Meshalfred - Bug #306: alfred netns / Could not find transtable_global for interface bat0https://www.open-mesh.org/issues/306?journal_id=9342016-11-01T12:12:50ZSven Eckelmann
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li><li><strong>Assignee</strong> set to <i>Jean-Jacques Sarton</i></li></ul><p>Please test</p>
<ul>
<li><a class="external" href="https://patchwork.open-mesh.org/project/b.a.t.m.a.n./patch/20161101121213.15607-1-sven@narfation.org/">https://patchwork.open-mesh.org/project/b.a.t.m.a.n./patch/20161101121213.15607-1-sven@narfation.org/</a></li>
<li><a class="external" href="https://patchwork.open-mesh.org/project/b.a.t.m.a.n./patch/20161101121937.31890-1-sven@narfation.org/">https://patchwork.open-mesh.org/project/b.a.t.m.a.n./patch/20161101121937.31890-1-sven@narfation.org/</a></li>
</ul> alfred - Bug #306: alfred netns / Could not find transtable_global for interface bat0https://www.open-mesh.org/issues/306?journal_id=9352016-11-01T13:38:45ZJean-Jacques Sartonjj.sarton@t-online.de
<ul></ul><p>I think that I have made the right corrections for this bug.</p>
<p>file netlink.h addedd at the end:<br /><pre>
int batadv_interface_check_netlink(const char *mesh_iface)
{
struct get_tq_netlink_opts opts = {
.tq = 0,
.found = false,
.query_opts = {
.err = 0,
},
};
int ret = 0;
memset(&opts.mac, 0, ETH_ALEN);
ret = netlink_query_common(mesh_iface, BATADV_CMD_GET_ORIGINATORS,
get_tq_netlink_cb, &opts.query_opts);
if (ret < 0)
return ret;
memset(&opts.mac, 0, ETH_ALEN);
ret = netlink_query_common(mesh_iface, BATADV_CMD_GET_ORIGINATORS,
get_tq_netlink_cb, &opts.query_opts);
if (ret < 0)
return ret;
return 0;
}
</pre><br />netlink.h added:<br /><pre>
int batadv_interface_check_netlink(const char *mesh_iface);
</pre></p>
<p>bat_adv_query.c replaced<br /><pre>
int batadv_interface_check(const char *mesh_iface)
</pre><br />whith:<br /><pre>
int batadv_interface_check_debugfs(const char *mesh_iface)
</pre><br />Added after int batadv_interface_check_debugfs(const char *mesh_iface) {...}<br /><pre>
int batadv_interface_check(const char *mesh_iface)
{
int ret = 0;
enable_net_admin_capability(1);
ret = batadv_interface_check_netlink(mesh_iface);
enable_net_admin_capability(0);
if ( ret < 0 )
return batadv_interface_check_debugfs(mesh_iface);
return 0;
}
</pre></p> alfred - Bug #306: alfred netns / Could not find transtable_global for interface bat0https://www.open-mesh.org/issues/306?journal_id=9362016-11-01T13:46:28ZSven Eckelmann
<ul></ul><p>Please submit the full patch via the mailing list as described in <a class="wiki-page" href="https://www.open-mesh.org/projects/open-mesh/wiki/Contribute#Submitting-patches">Contribute</a></p>
<p>PS: batadv_interface_check_netlink looks broken to me</p> alfred - Bug #306: alfred netns / Could not find transtable_global for interface bat0https://www.open-mesh.org/issues/306?journal_id=9372016-11-01T14:39:18ZJean-Jacques Sartonjj.sarton@t-online.de
<ul></ul><p>I have sen the patch.</p>
<p>You are right, I had to check ORIGINATORS and TRANSTABLE_GLOBAL.</p>
<p>I have send the corrected part</p> alfred - Bug #306: alfred netns / Could not find transtable_global for interface bat0https://www.open-mesh.org/issues/306?journal_id=9602016-11-06T09:42:11ZSven Eckelmann
<ul><li><strong>Assignee</strong> changed from <i>Jean-Jacques Sarton</i> to <i>Simon Wunderlich</i></li></ul><p>Jean-Jacques was not fixing the problems we found in his patch. I have therefore fixed them myself and submitted it to the mailing list <a class="external" href="https://patchwork.open-mesh.org/project/b.a.t.m.a.n./patch/20161106093738.17010-1-sven@narfation.org/">https://patchwork.open-mesh.org/project/b.a.t.m.a.n./patch/20161106093738.17010-1-sven@narfation.org/</a></p>
<p>The version v7 was chosen because this seemed to be the 7th submission of the patch. Jean-Jacques has not really numbered his versions very well. So I am sorry about any possible confusions.</p> alfred - Bug #306: alfred netns / Could not find transtable_global for interface bat0https://www.open-mesh.org/issues/306?journal_id=9692016-11-24T08:40:16ZSven Eckelmann
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Patch was applied a while ago: <a class="external" href="https://git.open-mesh.org/alfred.git/commit/2310c47f0ad7aadff0adac6f9879bf849c3a6356">https://git.open-mesh.org/alfred.git/commit/2310c47f0ad7aadff0adac6f9879bf849c3a6356</a></p> alfred - Bug #306: alfred netns / Could not find transtable_global for interface bat0https://www.open-mesh.org/issues/306?journal_id=10322016-12-16T08:41:01ZSven Eckelmann
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul><p>Fix is part of the release 2016.5</p> alfred - Bug #306: alfred netns / Could not find transtable_global for interface bat0https://www.open-mesh.org/issues/306?journal_id=10522017-02-10T23:53:50ZSven Eckelmann
<ul><li><strong>Target version</strong> set to <i>2016.5</i></li></ul>