Project

General

Profile

Actions

Bug #227

closed

Lock not held while in batadv_tvlv_container_remove

Added by Heiko Wundram over 8 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Low
Assignee:
Target version:
Start date:
12/15/2015
Due date:
% Done:

0%

Estimated time:

Description

On an ARMv7l system, I'm seeing the following error while using batman-adv 2015.2:

Dec 15 14:19:57 gw kernel: [c1] ------------[ cut here ]------------
Dec 15 14:19:57 gw kernel: [c1] WARNING: at /var/lib/dkms/batman-adv/2015.2/build/net/batman-adv/main.c:750 batadv_tvlv_container_remove+0x94/0xa0 [batman_adv]()
Dec 15 14:19:57 gw kernel: [c1] Modules linked in: 8021q garp mrp bridge stp llc ip6table_filter ip6table_nat nf_conntrack_ipv6 nf_defrag_ipv6 nf_nat_ipv6 ip6table_mangle ip6_tables xt_hashlimit xt_multiport xt_conntrack iptable_filter cdc_ether xt_TCPMSS usbnet r8152 xt_tcpmss iptable_mangle iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack ip_tables spi_s3c64xx ipcomp batman_adv(O)
Dec 15 14:19:57 gw kernel: [c1] CPU: 1 PID: 2818 Comm: kworker/u16:0 Tainted: G        W  O 3.10.92-64 #1
Dec 15 14:19:57 gw kernel: [c1] Workqueue: bat_events batadv_send_outstanding_bat_ogm_packet [batman_adv]
Dec 15 14:19:57 gw kernel: [c1] Backtrace: 
Dec 15 14:19:57 gw kernel: [c1] [<c0012da4>] (dump_backtrace+0x0/0x114) from [<c0013014>] (show_stack+0x20/0x24)
Dec 15 14:19:57 gw kernel: [c1]  r7:000002ee r6:bf01d340 r5:00000009 r4:00000000
Dec 15 14:19:57 gw kernel: [c1] [<c0012ff4>] (show_stack+0x0/0x24) from [<c05fc4d0>] (dump_stack+0x24/0x28)
Dec 15 14:19:57 gw kernel: [c1] [<c05fc4ac>] (dump_stack+0x0/0x28) from [<c002b4bc>] (warn_slowpath_common+0x64/0x7c)
Dec 15 14:19:57 gw kernel: [c1] [<c002b458>] (warn_slowpath_common+0x0/0x7c) from [<c002b590>] (warn_slowpath_null+0x2c/0x34)
Dec 15 14:19:57 gw kernel: [c1]  r9:de29ea50 r8:00000001 r7:00000004 r6:00001c00 r5:de29e5c0\x0ar4:dcb68540
Dec 15 14:19:57 gw kernel: [c1] [<c002b564>] (warn_slowpath_null+0x0/0x34) from [<bf00c08c>] (batadv_tvlv_container_remove+0x94/0xa0 [batman_adv])
Dec 15 14:19:57 gw kernel: [c1] [<bf00bff8>] (batadv_tvlv_container_remove+0x0/0xa0 [batman_adv]) from [<bf00cc8c>] (batadv_tvlv_container_register+0xa8/0xf8 [batman_adv])
Dec 15 14:19:57 gw kernel: [c1]  r5:de29e5c0 r4:dcb68280
Dec 15 14:19:57 gw kernel: [c1] [<bf00cbe4>] (batadv_tvlv_container_register+0x0/0xf8 [batman_adv]) from [<bf0177d4>] (batadv_tt_tvlv_container_update+0x190/0x1cc [batman_adv])
Dec 15 14:19:57 gw kernel: [c1] [<bf017644>] (batadv_tt_tvlv_container_update+0x0/0x1cc [batman_adv]) from [<bf018200>] (batadv_tt_local_commit_changes_nolock+0x374/0x394 [batman_adv])
Dec 15 14:19:57 gw kernel: [c1] [<bf017e8c>] (batadv_tt_local_commit_changes_nolock+0x0/0x394 [batman_adv]) from [<bf01b960>] (batadv_tt_local_commit_changes+0x30/0x3c [batman_adv])
Dec 15 14:19:57 gw kernel: [c1] [<bf01b930>] (batadv_tt_local_commit_changes+0x0/0x3c [batman_adv]) from [<bf001308>] (batadv_iv_ogm_schedule+0x380/0x3b4 [batman_adv])
Dec 15 14:19:57 gw kernel: [c1]  r5:de29e000 r4:de29e5c0
Dec 15 14:19:57 gw kernel: [c1] [<bf000f88>] (batadv_iv_ogm_schedule+0x0/0x3b4 [batman_adv]) from [<bf013514>] (batadv_send_outstanding_bat_ogm_packet+0xf0/0x100 [batman_adv])
Dec 15 14:19:57 gw kernel: [c1] [<bf013424>] (batadv_send_outstanding_bat_ogm_packet+0x0/0x100 [batman_adv]) from [<c004a760>] (process_one_work+0x1b0/0x578)
Dec 15 14:19:57 gw kernel: [c1]  r7:dd391200 r6:df019c00 r5:dd010680 r4:dd29dc20
Dec 15 14:19:57 gw kernel: [c1] [<c004a5b0>] (process_one_work+0x0/0x578) from [<c004ac64>] (worker_thread+0x13c/0x3c8)
Dec 15 14:19:57 gw kernel: [c1] [<c004ab28>] (worker_thread+0x0/0x3c8) from [<c0051a7c>] (kthread+0xc4/0xc8)
Dec 15 14:19:57 gw kernel: [c1] [<c00519b8>] (kthread+0x0/0xc8) from [<c000e820>] (ret_from_fork+0x14/0x20)
Dec 15 14:19:57 gw kernel: [c1]  r7:00000000 r6:00000000 r5:c00519b8 r4:dd97fe14
Dec 15 14:19:57 gw kernel: [c1] ---[ end trace bde3526140ca6de6 ]---

This error repeats every five seconds, but does not seem to impact stability of the system as a whole. The running system is:

Linux gw 3.10.92-64 #1 SMP PREEMPT Mon Nov 23 15:13:42 BRST 2015 armv7l armv7l armv7l GNU/Linux

(i.e. the default kernel for an XU3 system), and uses the module as a DKMS built with the standard debian DKMS-infrastructure.

Actions

Also available in: Atom PDF