https://www.open-mesh.org/https://www.open-mesh.org/favicon.ico?16699090422011-03-26T20:24:15ZOpen Meshbatman-adv - Bug #136: check hash_add failhttps://www.open-mesh.org/issues/136?journal_id=1112011-03-26T20:24:15ZAnonymous
<ul><li><strong>Category</strong> set to <i>2</i></li><li><strong>Assignee</strong> deleted (<del><i>Anonymous</i></del>)</li></ul> batman-adv - Bug #136: check hash_add failhttps://www.open-mesh.org/issues/136?journal_id=1552011-05-15T09:55:22ZAnonymous
<ul><li><strong>Assignee</strong> set to <i>Simon Wunderlich</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>70</i></li></ul><p>hash_add now doesn't allocate memory anymore. Thus it is not possible to leak memory in that function after commit:4c4236064501e85915087f00a370df8d9f43028d - but the function still may fail and we have to check that in the calling function.</p> batman-adv - Bug #136: check hash_add failhttps://www.open-mesh.org/issues/136?journal_id=2052011-11-01T10:35:25ZSimon Wunderlichsw@simonwunderlich.de
<ul></ul><p>it is not yet checked everywhere - we miss the check in translation-table.c at two points.</p> batman-adv - Bug #136: check hash_add failhttps://www.open-mesh.org/issues/136?journal_id=2342012-07-01T10:13:39ZAntonio Quartulli
<ul><li><strong>% Done</strong> changed from <i>70</i> to <i>90</i></li></ul><p>After Simon's commit c2e935f5da562f008f77bb12995ebc10705cb15a also the two hash_add() invocations in translation-table.c are now checked.</p> batman-adv - Bug #136: check hash_add failhttps://www.open-mesh.org/issues/136?journal_id=2352012-07-01T20:36:55ZSimon Wunderlichsw@simonwunderlich.de
<ul></ul><p>nice. as far as I see, what we don't handle yet ist:</p>
<ul>
<li>out of memory in originator.c / batadv_orig_hash_add_if() - we leave orig table in bad shape, also the return code is never checked.</li>
</ul>
<p>Apart from that, I can't find any other unchecked usages of batadv_hash_add()</p> batman-adv - Bug #136: check hash_add failhttps://www.open-mesh.org/issues/136?journal_id=2362012-07-01T20:53:09ZSimon Wunderlichsw@simonwunderlich.de
<ul></ul><p>Simon Wunderlich wrote:</p>
<blockquote>
<p>nice. as far as I see, what we don't handle yet ist:</p>
<ul>
<li>out of memory in originator.c / batadv_orig_hash_add_if() - we leave orig table in bad shape, also the return code is never checked.</li>
</ul>
<p>Apart from that, I can't find any other unchecked usages of batadv_hash_add()</p>
</blockquote>
<p>well, I've just sent a patch for that (although it is not completely related, it just coincides to have hash_add in the name).</p>
<p>@Antonio, @Sven, I'd suggest to close the ticket now?</p> batman-adv - Bug #136: check hash_add failhttps://www.open-mesh.org/issues/136?journal_id=2372012-07-01T20:54:56ZSimon Wunderlichsw@simonwunderlich.de
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>90</i> to <i>100</i></li></ul> batman-adv - Bug #136: check hash_add failhttps://www.open-mesh.org/issues/136?journal_id=2392012-08-07T17:13:37ZSimon Wunderlichsw@simonwunderlich.de
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul> batman-adv - Bug #136: check hash_add failhttps://www.open-mesh.org/issues/136?journal_id=11112017-02-11T08:39:49ZSven Eckelmann
<ul><li><strong>Target version</strong> set to <i>2012.0.0</i></li></ul>